Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30523 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 2:
(4 comments)
File include/osmo-bts/bts.h:
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/04980958_158e0886 PS1, Line 68: prefers
"Prefers" implies that it supports both but simply has a preference. […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/00d6bfab_f926f23a PS1, Line 72: BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993
I suggest to use slightly different, consistent naming here: […]
Thats indeed not consistant. I forgot to rename one of the constants. There are other constants that have _SPEECH_H_V1_ in their names. So lets stick to that variant.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/8e5ae522_f8de97f2 PS1, Line 1920: if (bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993)
I believe it should be clarified in a comment that the only difference between the two formats is ba […]
Done
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/97b484a9_bf55d3dc PS1, Line 1925: memcpy(msgb_put(msg, 1), "\x00", 1);
msgb_put_u8(msg, 0x00)
Done