Attention is currently required from: fixeria.

View Change

4 comments:

• File include/osmo-bts/bts.h:

  • Patch Set #1, Line 68: prefers

    "Prefers" implies that it supports both but simply has a preference. […]

    Done

  • Patch Set #1, Line 72: BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993

    I suggest to use slightly different, consistent naming here: […]

    Thats indeed not consistant. I forgot to rename one of the constants. There are other constants that have _SPEECH_H_V1_ in their names. So lets stick to that variant.

• File src/common/l1sap.c:

  • Patch Set #1, Line 1920: if (bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RFC5993)

    I believe it should be clarified in a comment that the only difference between the two formats is ba […]

    Done

  • Patch Set #1, Line 1925: memcpy(msgb_put(msg, 1), "\x00", 1);

    msgb_put_u8(msg, 0x00)

    Done

To view, visit change 30523. To unsubscribe, or for help writing mail filters, visit settings.