Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540 )
Change subject: PCU_Tests: test NACC procedure with UTRAN and E-UTRAN cell ......................................................................
Patch Set 3:
(4 comments)
File pcu/PCU_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/1db3cf2d_9759d... PS2, Line 5336: private function f_outbound_nacc_success_utran_eutran(inout GprsMS ms, PCUIF_info_ind info_ind,
I think you can really split the UTRAN and EUTRAN cases in different functions, it will be easier to […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/8bc1fef0_7ab56... PS2, Line 5351: cell_chg_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF_EUTRAN(ms.ul_tbf.tfi, req_earfcn, phys_layer_cell_id);
If this is the only thing that changes, maybe pass template (value) RlcmacUlCtrlMsg cell_chg_notif a […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/aefa301b_7e15d... PS2, Line 5378: private function f_outbound_nacc_success(inout GprsMS ms, PCUIF_info_ind info_ind,
This one should be renamed to _geran in another patch maybe?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33540/comment/9d322a86_edf0a... PS2, Line 5427: function f_TC_nacc_outbound_success(integer ran_type) runs on RAW_PCU_Test_CT {
please enum or string, this is totally hack
Done