Attention is currently required from: pespin.

View Change

4 comments:

• File pcu/PCU_Tests.ttcn:

  • Patch Set #2, Line 5336: private function f_outbound_nacc_success_utran_eutran(inout GprsMS ms, PCUIF_info_ind info_ind,

    I think you can really split the UTRAN and EUTRAN cases in different functions, it will be easier to […]

    Done

  • Patch Set #2, Line 5351: cell_chg_notif := ts_RlcMacUlCtrl_PKT_CELL_CHG_NOTIF_EUTRAN(ms.ul_tbf.tfi, req_earfcn, phys_layer_cell_id);

    If this is the only thing that changes, maybe pass template (value) RlcmacUlCtrlMsg cell_chg_notif a […]

    Done

  • Patch Set #2, Line 5378: private function f_outbound_nacc_success(inout GprsMS ms, PCUIF_info_ind info_ind,

    This one should be renamed to _geran in another patch maybe?

    Done

  • Patch Set #2, Line 5427: function f_TC_nacc_outbound_success(integer ran_type) runs on RAW_PCU_Test_CT {

    please enum or string, this is totally hack

    Done

To view, visit change 33540. To unsubscribe, or for help writing mail filters, visit settings.