Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31071 )
Change subject: netdev: Fix compilation building with --disable-libmnl ......................................................................
Patch Set 1:
(2 comments)
File src/core/netdev.c:
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/287bd655_f7eff6f0 PS1, Line 845:
You could actually have the ifdef here and log/return -ENOTSUP. […]
I would prefer to keep them below, since the netns stuff is totally orthogonal to using ioctl or libmnl or whatever.
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/5ab526c4_4a321c60 PS1, Line 855: LOGNETDEV(netdev, LOGL_NOTICE, "%s: NOT SUPPORTED. Build libosmocore with --enable-libmnl.\n", __func__);
I'm torn whether these should actually abort the program. […]
I'll move it to ERROR.