Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31071 ) Change subject: netdev: Fix compilation building with --disable-libmnl ...................................................................... Patch Set 1: (2 comments) File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/287bd655_f7eff6f0 PS1, Line 845:
You could actually have the ifdef here and log/return -ENOTSUP. […] I would prefer to keep them below, since the netns stuff is totally orthogonal to using ioctl or libmnl or whatever.
https://gerrit.osmocom.org/c/libosmocore/+/31071/comment/5ab526c4_4a321c60 PS1, Line 855: LOGNETDEV(netdev, LOGL_NOTICE, "%s: NOT SUPPORTED. Build libosmocore with --enable-libmnl.\n", __func__);
I'm torn whether these should actually abort the program. […] I'll move it to ERROR.
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I62bdea075afb9e0cc2bbcec6dd3a930e8f7bbc40 Gerrit-Change-Number: 31071 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jan 2023 16:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment