Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email )
Change subject: Add Emscripten build support and JS callback logging backend
......................................................................
Patch Set 27: Code-Review+1
(2 comments)
File src/core/logging_emscripten.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/3d912597_231ddb50?u... :
PS26, Line 45: const int msgLen = MAX_LOG_SIZE;
Sounds good, I’ve updated the code accordingly and now use MAX_LOG_SIZE directly, dropping the extra […]
Done
File src/core/logging_emscripten.c:
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/f96df132_fe0f2623?u... :
PS27, Line 49: rc = vsnprintf(msg, sizeof(msg), format, ap);
BTW, you are losing context information here, like file&line.
You may want to call log_output_buf() here instead (or implement parts of it here to add file&line), but up to you, you know better how the stuff shows up in the emscripten log.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31
Gerrit-Change-Number: 41813
Gerrit-PatchSet: 27
Gerrit-Owner: Timur Davydov
dtv.comp@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: Timur Davydov
dtv.comp@gmail.com
Gerrit-Comment-Date: Wed, 04 Feb 2026 11:23:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: Timur Davydov
dtv.comp@gmail.com