Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith.

Patch set 27:Code-Review +1

View Change

2 comments:

• File src/core/logging_emscripten.c:

  • Patch Set #26, Line 45: const int msgLen = MAX_LOG_SIZE;

    Sounds good, I’ve updated the code accordingly and now use MAX_LOG_SIZE directly, dropping the extra […]

    Done

• File src/core/logging_emscripten.c:

  • Patch Set #27, Line 49: rc = vsnprintf(msg, sizeof(msg), format, ap);

    BTW, you are losing context information here, like file&line.

    You may want to call log_output_buf() here instead (or implement parts of it here to add file&line), but up to you, you know better how the stuff shows up in the emscripten log.

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.