Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30277
)
Change subject: paging: Introduce BTS stat paging:request_queue_length
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30277/comment/6fc7ead0_e22eadd9
PS1, Line 92: to_be_deleted->bts
Why not paging_bts->bts_statg? I see it's used
above.
Because "paging_bts" is not a gsm_bts, but a struct
gsm_bts_paging_state, so it would be paging_bts->bts->bts_statg. So it doesn't
really matter, it's the same bts pointer in the end.
https://gerrit.osmocom.org/c/osmo-bsc/+/30277/comment/ef39122c_5f835b11
PS1, Line 470: bts
This is also confusing: above you're decrementing
pending_requests_len via 'bts_entry', but here you […]
Same, bts_entry is
struct gsm_bts_paging_state, which is basically "bts->paging".
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/30277
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6d296cdeba1392ef95fc31f6c04210c73f1b23e5
Gerrit-Change-Number: 30277
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Nov 2022 19:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment