Attention is currently required from: osmith, msuraev.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/30022 )
Change subject: Initial user manual for osmo-e1d
......................................................................
Patch Set 5: -Code-Review
(6 comments)
File doc/manuals/Makefile.am:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/2adc3de8_f46cbf94
PS1, Line 8: ASCIIDOC = osmoe1d-usermanual.adoc
trailing whitespace
Please fix.
File doc/manuals/chapters/client-interface.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/1114f9a4_5ae794ac
PS1, Line 30: When opening a timeslot, the client specifies the _mode_.
trailing whitespace
Please fix.
File doc/manuals/chapters/overview.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/e40b2400_ad0d6d84
PS1, Line 29: .How osmo-e1d fits in the overall system achitecture
'achitecture' may be misspelled - perhaps
'architecture'?
Please fix.
File doc/manuals/chapters/overview.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/2527582c_0b31968d
PS3, Line 103: The osmo-e1d _vpair_ is not actual hardwarr, but a virtual pair of E1
Typo: hardware
Done
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/14dc8b6e_19d9b129
PS3, Line 8: *osmo-e1d* [-h] [-d 'DBGMASK'] [-c 'CONFIGFILE']
[-V] missing
Done
File doc/manuals/chapters/tdmoip.adoc:
https://gerrit.osmocom.org/c/osmo-e1d/+/30022/comment/b87be2dc_3e28376e
PS3, Line 55: local-bind 0.0.0.0 9999 <2>
I think it would be easier to grasp when using the
same port number as in the client configuration a […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/30022
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I42f8da1990092b5a3d8c63fde33e49978ad83281
Gerrit-Change-Number: 30022
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Nov 2022 10:17:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment