Attention is currently required from: osmith, msuraev.

Patch set 5:-Code-Review

View Change

6 comments:

• File doc/manuals/Makefile.am:

  • Patch Set #1, Line 8: ASCIIDOC = osmoe1d-usermanual.adoc

    trailing whitespace

    Please fix.

• File doc/manuals/chapters/client-interface.adoc:

  • Patch Set #1, Line 30: When opening a timeslot, the client specifies the _mode_.

    trailing whitespace

    Please fix.

• File doc/manuals/chapters/overview.adoc:

  • Patch Set #1, Line 29: .How osmo-e1d fits in the overall system achitecture

    'achitecture' may be misspelled - perhaps 'architecture'?

    Please fix.

• File doc/manuals/chapters/overview.adoc:

  • Patch Set #3, Line 103: The osmo-e1d _vpair_ is not actual hardwarr, but a virtual pair of E1

    Typo: hardware

    Done

• File doc/manuals/chapters/running.adoc:

  • Patch Set #3, Line 8: *osmo-e1d* [-h] [-d 'DBGMASK'] [-c 'CONFIGFILE']

    [-V] missing

    Done

• File doc/manuals/chapters/tdmoip.adoc:

  • Patch Set #3, Line 55: local-bind 0.0.0.0 9999 <2>

    I think it would be easier to grasp when using the same port number as in the client configuration a […]

    Done

To view, visit change 30022. To unsubscribe, or for help writing mail filters, visit settings.