[L] Change in osmo-mgw[master]: mgw: CRCX: Split mgcp header pars parsing into a previous step

Attention is currently required from: daniel. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email ) Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 1: (3 comments) File include/osmocom/mgcp/mgcp_msg.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/f18233f3_3255f0b2?usp… : PS1, Line 29: #include <ctype.h> Done File include/osmocom/mgcp/mgcp_protocol.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/b96d8ab9_5d406d19?usp… : PS1, Line 31: //struct mgcp_parsed_body { : //}; Done File src/libosmo-mgcp/mgcp_msg.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/d0bef322_cba38205?usp… : PS1, Line 176: * \param[in] endp pointer to endpoint (only used for log output, may be NULL) IMHO this style of passing objects deep in the state just for logging is wrong. We should log here the exact problem and then a more general problem with the whole context if needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1 Gerrit-Change-Number: 39224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 07 Jan 2025 10:51:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt;