Attention is currently required from: daniel.

View Change

3 comments:

• File include/osmocom/mgcp/mgcp_msg.h:

  • Patch Set #1, Line 29: #include <ctype.h>

    Seems unnecessary here

    Done

• File include/osmocom/mgcp/mgcp_protocol.h:

  • Patch Set #1, Line 31:

    //struct mgcp_parsed_body {
    //};
    

    Remove

    Done

• File src/libosmo-mgcp/mgcp_msg.c:

  • Patch Set #1, Line 176: * \param[in] endp pointer to endpoint (only used for log output, may be NULL)

    I don't know if these helped debug issues in the past, but this change also makes the log messages a […]

    IMHO this style of passing objects deep in the state just for logging is wrong. We should log here the exact problem and then a more general problem with the whole context if needed.

To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.