Attention is currently required from: neels, pespin, fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ......................................................................
Patch Set 21:
(5 comments)
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/2d227f65_b8c6e8be PS17, Line 280: uint8_t pgroup[3];
I think we should transfer the whole IMSI to osmo-bsc. […]
Done
File src/bts.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/ac835003_0c0765ba PS19, Line 284: bool use_dt_confirm;
I think it would be best to simply drop this bool, and explicitly check against received info_ind PC […]
Done
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/725827c8_9040d97c PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
Agree with the first part: Add the new message sending the whole IMSi and keep the backward compatib […]
Ack
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/770424d8_84967c35 PS19, Line 298: pgroup
Thats wired.
Since we are now sending the full IMSI this patch needs to be upgraded.
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/e54eec27_261b1b2e PS19, Line 769: LOGP(DL1IF, LOGL_NOTICE, "selected IMMEDIATE assignment confirmation method (MAC block as reference) is deprecated. OS#5927\n");
I think in here simply state that "PCUIF version 10 is deprecated" would be more interesting.
Done