Attention is currently required from: neels, pespin, fixeria.

View Change

5 comments:

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #17, Line 280: uint8_t pgroup[3];

    I think we should transfer the whole IMSI to osmo-bsc. […]

    Done

• File src/bts.h:

  • Patch Set #19, Line 284: bool use_dt_confirm;

    I think it would be best to simply drop this bool, and explicitly check against received info_ind PC […]

    Done

• File src/bts.cpp:

  • Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));

    Agree with the first part: Add the new message sending the whole IMSi and keep the backward compatib […]

    Ack

• File src/pcu_l1_if.cpp:

  • Patch Set #19, Line 298: pgroup

    Thats wired.

    Since we are now sending the full IMSI this patch needs to be upgraded.

  • Patch Set #19, Line 769: LOGP(DL1IF, LOGL_NOTICE, "selected IMMEDIATE assignment confirmation method (MAC block as reference) is deprecated. OS#5927\n");

    I think in here simply state that "PCUIF version 10 is deprecated" would be more interesting.

    Done

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.