7 Sep
2023
7 Sep
'23
7:38 p.m.
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34340?usp=email )
Change subject: bts-trx: Fix CCCH not enabled if BS_AG_BLKS_RES!=1 is provided by BSC ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/34340/comment/697156ab_97ef9f1b PS1, Line 635: lchan_deactivate I am wondering why can't we call `lchan_activate(lchan)` right after calling `lchan_deactivate(lchan)`? Perhaps because activation/deactivation is asynchronous for DSP based models and we're waiting for some kind of confirmation? Not blocking, just curious.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34340?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I61e1681fbaa2c993b529d58b581c99166b62bda3
Gerrit-Change-Number: 34340
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 07 Sep 2023 17:38:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment