Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email )
Change subject: ggsn: Introduce test TC_pdp4(6)_act_deact_mtu
......................................................................
Patch Set 3:
(3 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/5dc9e721_d0b4…
:
PS3, Line 248: f_vty_transceive(GGSNVTY, "apn internet");
Hmm I copied this from f_vty_set_gpdu_txseq(), which
seems to be executed on all tests, are you sure […]
Looking at the configs again,
the APNs have "no shutdown" at the end to enable them. Looks like osmo-ggsn
doesn't fail if you run "mtu ..." on an apn that was not previously defined,
so the additional ifs then are not strictly needed.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/ef7ea30c_c0fc…
:
PS3, Line 252: f_vty_transceive(GGSNVTY, "apn inet6");
if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf ==
GGSN_CONF_V6_ONLY) {
not needed
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/3f9ffea0_cdf0…
:
PS3, Line 256: f_vty_transceive(GGSNVTY, "apn inet46");
if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf ==
GGSN_CONF_V4V6_ONLY) {
not needed
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2ceb76a3a07b44f69937c9f5a040482320bca377
Gerrit-Change-Number: 38469
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Oct 2024 09:07:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>