Attention is currently required from: pespin.

View Change

3 comments:

• File ggsn_tests/GGSN_Tests.ttcn:

  • Patch Set #3, Line 248: f_vty_transceive(GGSNVTY, "apn internet");

    Hmm I copied this from f_vty_set_gpdu_txseq(), which seems to be executed on all tests, are you sure […]

    Looking at the configs again, the APNs have "no shutdown" at the end to enable them. Looks like osmo-ggsn doesn't fail if you run "mtu ..." on an apn that was not previously defined, so the additional ifs then are not strictly needed.

  • Patch Set #3, Line 252: f_vty_transceive(GGSNVTY, "apn inet6");

    if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V6_ONLY) {

    not needed

  • Patch Set #3, Line 256: f_vty_transceive(GGSNVTY, "apn inet46");

    if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V4V6_ONLY) {

    not needed

To view, visit change 38469. To unsubscribe, or for help writing mail filters, visit settings.