Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28667 )
Change subject: trxcon: introduce and use struct 'trxcon_inst' ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/1d470a02_a2c3f19f PS3, Line 44: void *priv; where is priv set through API below? I can't see it.
https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/44180d4a_c33dbc8a PS3, Line 55: struct trx_instance *trx_if_open(struct trxcon_inst *trxcon, This is a bit strange. All functions here are called trx_if_* but receive a trxcon_inst as object. You may want to clean up this.
File src/host/trxcon/src/trxcon.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28667/comment/64fb9ca2_4bd225b2 PS3, Line 351: trxcon->l1l->priv = trxcon; if some parts are to be turned up into a library you probably want to add setters and getters for these fields.