Attention is currently required from: fixeria.

Patch set 3:Code-Review +1

View Change

3 comments:

• File src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h:

  • Patch Set #3, Line 44: void *priv;

    where is priv set through API below? I can't see it.

  • Patch Set #3, Line 55: struct trx_instance *trx_if_open(struct trxcon_inst *trxcon,

    This is a bit strange. All functions here are called trx_if_* but receive a trxcon_inst as object. You may want to clean up this.

• File src/host/trxcon/src/trxcon.c:

  • Patch Set #3, Line 351: trxcon->l1l->priv = trxcon;

    if some parts are to be turned up into a library you probably want to add setters and getters for these fields.

To view, visit change 28667. To unsubscribe, or for help writing mail filters, visit settings.