Attention is currently required from: falconia.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34517?usp=email )
Change subject: SMS over GSUP: correctly route GSUP responses to MT SMS ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/34517/comment/98c97979_285057ce PS1, Line 1258: talloc_size FYI, you could use `talloc_memdup()` here:
``` trans->sms.gsup_source_name = talloc_memdup(trans, gsup_source_name, gsup_source_name_len); ```
This is identical to your code, but shorter.
https://gerrit.osmocom.org/c/osmo-msc/+/34517/comment/c00580b8_e83bc5e6 PS1, Line 1260: msgb_free IMO, this conditional block is a bit out of place here. If you move it above, you would not need to do `msgb_free(msg)`. Not critical.