Attention is currently required from: falconia.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/libmsc/gsm_04_11.c:

  • Patch Set #1, Line 1258: talloc_size

    FYI, you could use `talloc_memdup()` here:

    ```
    trans->sms.gsup_source_name = talloc_memdup(trans, gsup_source_name,
                                                       gsup_source_name_len);
    ```

    This is identical to your code, but shorter.

  • Patch Set #1, Line 1260: msgb_free

    IMO, this conditional block is a bit out of place here. If you move it above, you would not need to do `msgb_free(msg)`. Not critical.

To view, visit change 34517. To unsubscribe, or for help writing mail filters, visit settings.