Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27646 )
Change subject: jenkins: Validate gsm 08.58 IEs are added to tlv_definition ......................................................................
Patch Set 3:
(2 comments)
File include/osmocom/gsm/protocol/gsm_08_58.h:
https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/3b749c45_48dbde71 PS3, Line 388: RSL_IE_IPAC_RTP_PAYLOAD2 = 0xfc,
Why changing spacing in this patch?
It is needed to have same syntax in all enums, with a separation between name and equal. Making them more regular makes easy to parse the code.
File src/gsm/rsl.c:
https://gerrit.osmocom.org/c/libosmocore/+/27646/comment/58aa171f_35fc812a PS3, Line 128: [RSL_IE_IPAC_SRTP_CONFIG] = { TLV_TYPE_TLV },
This looks unrelated, please submit a separate change.
It's not unrelated, precisely having this line makes the new contrib/jenkins.sh pass, since the new checks detects they are lacking.