Attention is currently required from: fixeria.

View Change

2 comments:

• File include/osmocom/gsm/protocol/gsm_08_58.h:

  • Patch Set #3, Line 388: RSL_IE_IPAC_RTP_PAYLOAD2 = 0xfc,

    Why changing spacing in this patch?

    It is needed to have same syntax in all enums, with a separation between name and equal. Making them more regular makes easy to parse the code.

• File src/gsm/rsl.c:

  • Patch Set #3, Line 128: [RSL_IE_IPAC_SRTP_CONFIG] = { TLV_TYPE_TLV },

    This looks unrelated, please submit a separate change.

    It's not unrelated, precisely having this line makes the new contrib/jenkins.sh pass, since the new checks detects they are lacking.

To view, visit change 27646. To unsubscribe, or for help writing mail filters, visit settings.