Attention is currently required from: daniel, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39265?usp=email )
Change subject: client: Support generation of pcapng file format ......................................................................
Patch Set 8:
(3 comments)
File doc/manuals/chapters/client.adoc:
https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/01f3e45b_9d5c6dc3?usp... : PS8, Line 59: reate
create
Done
File include/osmo-pcap/osmo_pcap_file.h:
https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/0df37a3e_3053cca0?usp... : PS8, Line 87: /* uint32_t block_total_length */
looks like a leftover, because block_total_length is already in line 85
Nope, it's fine, the field is duplicated at the end of block_body so that the file can be navigated backwards. See pcapng spec 😊
File src/osmo_client_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39265/comment/da2123ef_81082df2?usp... : PS8, Line 389: .
(remove the dot?)
Done