Attention is currently required from: daniel, laforge, osmith.

View Change

3 comments:

• File doc/manuals/chapters/client.adoc:

  • Patch Set #8, Line 59: reate

    create

    Done

• File include/osmo-pcap/osmo_pcap_file.h:

  • Patch Set #8, Line 87: /* uint32_t block_total_length */

    looks like a leftover, because block_total_length is already in line 85

    Nope, it's fine, the field is duplicated at the end of block_body so that the file can be navigated backwards. See pcapng spec 😊

• File src/osmo_client_network.c:

  • Patch Set #8, Line 389: .

    (remove the dot?)

    Done

To view, visit change 39265. To unsubscribe, or for help writing mail filters, visit settings.