Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ......................................................................
Patch Set 3:
(4 comments)
File Transceiver52M/Transceiver.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c2c6ca89_074e5eab?usp=... : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); wrong indentation related to all other lines in this file.
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/df8a55eb_6c0bdd23?usp=... : PS3, Line 831: static bool match_cmd(const char *buf, This can be done in a previous separate commit.
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/479c73f3_0fcece3b?usp=... : PS3, Line 1026: return -EINVAL; This logic change looks unrelated to this patch, please split into several patches.
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/75d6bac3_be8879a7?usp=... : PS3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ This is a logic change, please split into separate patch.