Attention is currently required from: Timur Davydov.

View Change

4 comments:

• File Transceiver52M/Transceiver.h:

  • Patch Set #3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size);

    wrong indentation related to all other lines in this file.

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #3, Line 831: static bool match_cmd(const char *buf,

    This can be done in a previous separate commit.

  • Patch Set #3, Line 1026: return -EINVAL;

    This logic change looks unrelated to this patch, please split into several patches.

  • Patch Set #3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */

    This is a logic change, please split into separate patch.

To view, visit change 42410. To unsubscribe, or for help writing mail filters, visit settings.