Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS3:
BTW, you are missing some sort of comment here regarding the wq field cannot be changed despite bein […]
iiuc, this also pertains to the preceding struct member due to possible padding, so I've added a comment for the member `ofd_wq_mode`, too
File include/osmocom/core/gsmtap_util.h:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/14304b99_6d001547 PS3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti);
while at it, make gti const :)
Done
File src/core/logging_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/eb560cbb_99bc75f4 PS3, Line 54: struct gsmtap_inst;
This is not needed, you are already adding gsmtap_util.h abovewhich adds this line.
Done