Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email ) Change subject: gsmtap: Hide implementation of gsmtap_inst ...................................................................... Patch Set 4: (3 comments) Patchset: PS3:
BTW, you are missing some sort of comment here regarding the wq field cannot be changed despite bein […] iiuc, this also pertains to the preceding struct member due to possible padding, so I've added a comment for the member `ofd_wq_mode`, too
File include/osmocom/core/gsmtap_util.h: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/14304b99_6d001547 PS3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti);
while at it, make gti const :) Done
File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/eb560cbb_99bc75f4 PS3, Line 54: struct gsmtap_inst;
This is not needed, you are already adding gsmtap_util.h abovewhich adds this line. Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5 Gerrit-Change-Number: 34720 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Oct 2023 15:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment