Attention is currently required from: daniel, laforge, pespin.
3 comments:
Patchset:
BTW, you are missing some sort of comment here regarding the wq field cannot be changed despite bein […]
iiuc, this also pertains to the preceding struct member due to possible padding, so I've added a comment for the member `ofd_wq_mode`, too
File include/osmocom/core/gsmtap_util.h:
Patch Set #3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti);
while at it, make gti const :)
Done
File src/core/logging_gsmtap.c:
Patch Set #3, Line 54: struct gsmtap_inst;
This is not needed, you are already adding gsmtap_util.h abovewhich adds this line.
Done
To view, visit change 34720. To unsubscribe, or for help writing mail filters, visit settings.