[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode

Attention is currently required from: arehbein, daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ...................................................................... Patch Set 8: Code-Review-1 (3 comments) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/040b2000_09c23123 PS8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb); Can we call this callback function "tcp_xua_segmentation_cb"? (prepend"tcp_"). We already have eg. "m3ua_tcp_cli_read_cb". https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/ef538979_90119f23 PS8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb); You probably need to do "osmo_stream_cli_set_segmentation_cb(asp->client, NULL);" here too? https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/3cfe0e6a_8d800b83 PS8, Line 833: } so how are we now calling osmo_stream_srv_destroy() once the socket is detected as closed? I have the feeling you are missing a "if (msgb_length(msg) == 0) {" case here, like you added in the cli_ function. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Mar 2024 15:44:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment