Attention is currently required from: arehbein, daniel, laforge.

Patch set 8:Code-Review -1

View Change

3 comments:

• File src/osmo_ss7_asp.c:

  • Patch Set #8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb);

    Can we call this callback function "tcp_xua_segmentation_cb"? (prepend"tcp_").

    We already have eg. "m3ua_tcp_cli_read_cb".

  • Patch Set #8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb);

    You probably need to do "osmo_stream_cli_set_segmentation_cb(asp->client, NULL);" here too?

  • Patch Set #8, Line 833: }

    so how are we now calling osmo_stream_srv_destroy() once the socket is detected as closed?

    I have the feeling you are missing a "if (msgb_length(msg) == 0) {" case here, like you added in the cli_ function.

To view, visit change 35070. To unsubscribe, or for help writing mail filters, visit settings.