Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30575 )
Change subject: Convert ms_first_common_ts to struct gprs_rlcmac_pdch ......................................................................
Patch Set 2:
(1 comment)
File src/gprs_ms.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/a4caaa93_8a0aae25 PS2, Line 68: _ts
How about renaming s/_ts/_pdch/ to make the type of this field cleaner?
I thought about it already but I'm not sure it's really an improvement since the spec anyway talks about timeslots when explaining when/what is to be set, so having it named "ts" here also makes sense, I see no real need to change it (I'm not saying I'm against changing either, just that this is good enoguh so far).