Attention is currently required from: fixeria.
View Change
1 comment:
File src/gprs_ms.h:
Patch Set #2, Line 68: _ts
How about renaming s/_ts/_pdch/ to make the type of this field cleaner?
I thought about it already but I'm not sure it's really an improvement since the spec anyway talks about timeslots when explaining when/what is to be set, so having it named "ts" here also makes sense, I see no real need to change it (I'm not saying I'm against changing either, just that this is good enoguh so far).
To view, visit change 30575. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I19373939ec104d371e3e91422f018a8175cb0f89
Gerrit-Change-Number: 30575
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 11:07:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment