Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081?usp=email )
Change subject: Introduce concept of per-HNB persistent data structure ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/osmo-hnbgw/hnbgw_vty.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36081/comment/3d5deced_40a72fe0 PS2, Line 825: "hnb UMTS_CELL_ID",
Also not blocking, but I have to say I'm not really liking this concept of "persistent structure" […]
Ok, the data structures can be kept like this and mangled/renamed at a later point. But I'd really move the 1-string-param to be separated fields. You can do that in a follow-up commit but I would avoid merging this one and later on changing the vty interface.