Attention is currently required from: laforge.

Patch set 3:Code-Review +1

View Change

1 comment:

• File src/osmo-hnbgw/hnbgw_vty.c:

  • Patch Set #2, Line 825: "hnb UMTS_CELL_ID",

    > Also not blocking, but I have to say I'm not really liking this concept of "persistent structure" […]

    Ok, the data structures can be kept like this and mangled/renamed at a later point.
    But I'd really move the 1-string-param to be separated fields. You can do that in a follow-up commit but I would avoid merging this one and later on changing the vty interface.

To view, visit change 36081. To unsubscribe, or for help writing mail filters, visit settings.