Attention is currently required from: fixeria, pespin.
clufn has posted comments on this change by clufn. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277?usp=email )
Change subject: Enable the use of an UE requested IP type and address to be used for gtpv2 PDN Address Allocation ......................................................................
Patch Set 2:
(3 comments)
File src/conv.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/0cad876e_382f6... : PS1, Line 140: #v2_pdn_address_allocation{type = ipv4v6, address = get_v4v6(maps:get(ipv4,Address),maps:get(ipv6,Address))}.
missing space between parameters. Several times in lines 135-140.
Done
File src/epdg_ue_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/807e781a_444d7... : PS1, Line 264: Data1 = Data#ue_fsm_data{paa = conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},
I'd really prefer keeping the pdp address in our own format and only convert o gtp2 struct whenever […]
I could add the pdp type and address to the eu_fsm_data instead and then pass it through to the epdg_gtpc_s2b:create_session_req() and do the conversion in epdg_gtpc_s2b.erl
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/40277/comment/d34fb248_0a4ba... : PS1, Line 353: Data#ue_fsm_data.paa,
"conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress)" here, or even better, do it inside epdg_gtpc_s […]
Can do it here as PdpTypeNr and PdpAddress are not passed in the calling of the tunnel request function