Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• File src/conv.erl:

  • Patch Set #1, Line 140: #v2_pdn_address_allocation{type = ipv4v6, address = get_v4v6(maps:get(ipv4,Address),maps:get(ipv6,Address))}.

    missing space between parameters. Several times in lines 135-140.

    Done

• File src/epdg_ue_fsm.erl:

  • Patch Set #1, Line 264: Data1 = Data#ue_fsm_data{paa = conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress), apn = Apn},

    I'd really prefer keeping the pdp address in our own format and only convert o gtp2 struct whenever […]

    I could add the pdp type and address to the eu_fsm_data instead and then pass it through to the epdg_gtpc_s2b:create_session_req() and do the conversion in epdg_gtpc_s2b.erl

  • Patch Set #1, Line 353: Data#ue_fsm_data.paa,

    "conv:pdp_address_to_gtp2_paa(PdpTypeNr, PdpAddress)" here, or even better, do it inside epdg_gtpc_s […]

    Can do it here as PdpTypeNr and PdpAddress are not passed in the calling of the tunnel request function

To view, visit change 40277. To unsubscribe, or for help writing mail filters, visit settings.