Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email )
Change subject: personalization: add param_source.py, implement batch personalization ......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6: none of the comments from April addressed so far.
File pySim/esim/saip/param_source.py:
https://gerrit.osmocom.org/c/pysim/+/40096/comment/8e79fbef_792ad6f9?usp=ema... : PS3, Line 33: abstract
if it's abstract, should it be an abc. […]
I think the code has moved but the question remains. You describe in a comment that class ParamSource is "abstract", but it is not an abc.ABC. Do you have a different definition of "abstract"? An abstract base class usually has abstract methods which deriving classes must override. If they don't it will raise an exception.