Attention is currently required from: neels.

View Change

2 comments:

• Patchset:

  • Patch Set #6:

    none of the comments from April addressed so far.

• File pySim/esim/saip/param_source.py:

  • Patch Set #3, Line 33: abstract

    if it's abstract, should it be an abc. […]

    I think the code has moved but the question remains. You describe in a comment that class ParamSource is "abstract", but it is not an abc.ABC. Do you have a different definition of "abstract"? An abstract base class usually has abstract methods which deriving classes must override. If they don't it will raise an exception.

To view, visit change 40096. To unsubscribe, or for help writing mail filters, visit settings.