Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 )
Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ......................................................................
Patch Set 3:
(2 comments)
File src/host/layer23/include/osmocom/bb/common/sysinfo.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/f3f63051_9711ff7e PS2, Line 74: uint8_t supported;
this is really a bool right?
Yes, but <stdbool.h> in not used this file. The existing fields are using uint8_t for boolean logic. So I'd better stay consistent. This is not critical, right?
File src/host/layer23/src/common/sysinfo.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/5a382f01_dfacf9cf PS2, Line 893: s->gprs.ctrl_ack_type = !gco->CONTROL_ACK_TYPE; /* inversed */
why are you inverting this here?
Because I don't want to deal with the inverted logic in code using this field. But looking at it again, I think I should rename it to 'ctrl_ack_type_use_block' like in osmo-bsc.git.