Change in osmocom-bb[master]: layer23/sysinfo: implement decoding of SI13 Rest Octets

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 ) Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ...................................................................... Patch Set 3: (2 comments) File src/host/layer23/include/osmocom/bb/common/sysinfo.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/f3f63051_9711ff7e PS2, Line 74: uint8_t supported; Yes, but <stdbool.h> in not used this file. The existing fields are using uint8_t for boolean logic. So I'd better stay consistent. This is not critical, right? File src/host/layer23/src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/5a382f01_dfacf9cf PS2, Line 893: s->gprs.ctrl_ack_type = !gco->CONTROL_ACK_TYPE; /* inversed */ Because I don't want to deal with the inverted logic in code using this field. But looking at it again, I think I should rename it to 'ctrl_ack_type_use_block' like in osmo-bsc.git. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5 Gerrit-Change-Number: 30812 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 02 Jan 2023 16:13:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment