Attention is currently required from: pespin.

View Change

2 comments:

• File src/host/layer23/include/osmocom/bb/common/sysinfo.h:

  • Patch Set #2, Line 74: uint8_t supported;

    this is really a bool right?

    Yes, but <stdbool.h> in not used this file.
    The existing fields are using uint8_t for boolean logic.
    So I'd better stay consistent. This is not critical, right?

• File src/host/layer23/src/common/sysinfo.c:

  • Patch Set #2, Line 893: s->gprs.ctrl_ack_type = !gco->CONTROL_ACK_TYPE; /* inversed */

    why are you inverting this here?

    Because I don't want to deal with the inverted logic in code using this field. But looking at it again, I think I should rename it to 'ctrl_ack_type_use_block' like in osmo-bsc.git.

To view, visit change 30812. To unsubscribe, or for help writing mail filters, visit settings.