Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27467 )
Change subject: bsc_nat_fsm: tweak forwarding log messages ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc-nat/bsc_nat.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27467/comment/42d9af46_816e7570 PS1, Line 60: snprintf(buf, sizeof(buf), "PC=%s in %s", osmo_ss7_pointcode_print(NULL, addr->pc),
Sound like we can improve/shorten this further: CN-PC=%s and RAN-PC=%s
That's shorter yes, but I'd argue "PC=%s in RAN" and "PC=%s in CN" is more readable and fits better with "BSC(PC=%s)" and "MSC(PC=%s)" in later patches. You gave +1 so it seems it's not that important to you and I'll leave it as is.