Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-bsc-nat/bsc_nat.c:

  • Patch Set #1, Line 60: snprintf(buf, sizeof(buf), "PC=%s in %s", osmo_ss7_pointcode_print(NULL, addr->pc),

    Sound like we can improve/shorten this further: CN-PC=%s and RAN-PC=%s

    That's shorter yes, but I'd argue "PC=%s in RAN" and "PC=%s in CN" is more readable and fits better with "BSC(PC=%s)" and "MSC(PC=%s)" in later patches. You gave +1 so it seems it's not that important to you and I'll leave it as is.

To view, visit change 27467. To unsubscribe, or for help writing mail filters, visit settings.