Attention is currently required from: dexter.
neels has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42043?usp=email )
Change subject: esim/http_json_api: add alternative API interface ......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6: I would vote for a simpler approach, without needing to interfere with class instantiation: choose a different class name for the new client, leave the "legacy" class as-is, except, if needed, moving some bits to a new base class that old and new implementations can inherit from. IMHO that should be far easier to read and maintain.
File pySim/esim/http_json_api.py:
https://gerrit.osmocom.org/c/pysim/+/42043/comment/7f2a94a1_dc29af89?usp=ema... : PS6, Line 224: cls_attr = { attr_name: getattr(cls, attr_name) for attr_name in dir(cls) if not match("__.*__", attr_name) } if not attr_name.startswith('__')