Attention is currently required from: dexter.

View Change

2 comments:

• Patchset:

  • Patch Set #6:

    I would vote for a simpler approach, without needing to interfere with class instantiation: choose a different class name for the new client, leave the "legacy" class as-is, except, if needed, moving some bits to a new base class that old and new implementations can inherit from. IMHO that should be far easier to read and maintain.

• File pySim/esim/http_json_api.py:

  • Patch Set #6, Line 224: cls_attr = { attr_name: getattr(cls, attr_name) for attr_name in dir(cls) if not match("__.*__", attr_name) }

    if not attr_name.startswith('__')

To view, visit change 42043. To unsubscribe, or for help writing mail filters, visit settings.