fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42390?usp=email )
Change subject: bsc: fix copy-paste in TC_lcls_gcr_bway_codec_mismatch ......................................................................
bsc: fix copy-paste in TC_lcls_gcr_bway_codec_mismatch
The comment says that:
* first call leg uses FR, * second call leg uses HR,
however the code actually modifies the first call leg to use HR.
The test still exercises a codec mismatch, so LCLS non-activation is still triggered, but the leg roles are swapped relative to the stated intent. Fix this to avoid confusion.
Change-Id: Ie795516a447976ffe7b94ff8efcc649af0e37790 --- M bsc/BSC_Tests_LCLS.ttcn 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve
diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn index 37b6198..3def9f2 100644 --- a/bsc/BSC_Tests_LCLS.ttcn +++ b/bsc/BSC_Tests_LCLS.ttcn @@ -409,7 +409,7 @@
/* The second call leg uses half-rate */ pars_b := pars_a; - pars_a.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR})); + pars_b.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR}));
/* first call is not possible to be LS (no second leg yet) */ pars_a.lcls.exp_sts := LCLS_STS_not_possible_ls;