fixeria submitted this change.

View Change

Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve
bsc: fix copy-paste in TC_lcls_gcr_bway_codec_mismatch

The comment says that:

* first call leg uses FR,
* second call leg uses HR,

however the code actually modifies the first call leg to use HR.

The test still exercises a codec mismatch, so LCLS non-activation
is still triggered, but the leg roles are swapped relative to the
stated intent. Fix this to avoid confusion.

Change-Id: Ie795516a447976ffe7b94ff8efcc649af0e37790
---
M bsc/BSC_Tests_LCLS.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn
index 37b6198..3def9f2 100644
--- a/bsc/BSC_Tests_LCLS.ttcn
+++ b/bsc/BSC_Tests_LCLS.ttcn
@@ -409,7 +409,7 @@

/* The second call leg uses half-rate */
pars_b := pars_a;
- pars_a.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR}));
+ pars_b.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR}));

/* first call is not possible to be LS (no second leg yet) */
pars_a.lcls.exp_sts := LCLS_STS_not_possible_ls;

To view, visit change 42390. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie795516a447976ffe7b94ff8efcc649af0e37790
Gerrit-Change-Number: 42390
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>