Attention is currently required from: daniel, fixeria.
lynxis lazus has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email )
Change subject: gprs_gmm_parse_ra_upd_req(): handle unknown IEs gracefully
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I had the same idea and wasn't yet 100% sure. But I would agree, just break and log,
but as long it is only an unknown type, try to process and fails later when missing some
mandatory TLVs.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/38835?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I341565cb932d30d953ebd27d6b87f930cd8fa229
Gerrit-Change-Number: 38835
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes